1.8.0alpha3 delete_verb() bug and patch

• Date: Wed, 27 Dec 1995 22:26:02 PST
• From:
  sysop@calbbs.com

There is a bug in verbs.c - bf_delete_verb() that prevented the builtin
function delete_verb() from doing very much. (Version 1.8.0alpha3)

Replace the following code in the bf_delete_verb() function in verbs.c:

    if ((e = validate_verb_descriptor(desc)) != E_NONE)
        /* Do nothing; e is already set. */
    if (!valid(oid))
        e = E_INVARG;
    else if (!db_object_allows(oid, progr, FLAG_WRITE))
        e = E_PERM;
    else {
        h = find_described_verb(oid, desc);
        if (h.ptr)
            db_delete_verb(h);
        else
            e = E_VERBNF;
    }

With the following code:

    if ((e = validate_verb_descriptor(desc)) == E_NONE) {
        if (!valid(oid))
            e = E_INVARG;
        else if (!db_object_allows(oid, progr, FLAG_WRITE))
            e = E_PERM;
        else {
            h = find_described_verb(oid, desc);
            if (h.ptr)
                db_delete_verb(h);
            else
                e = E_VERBNF;
        }
    }

This *should* fix the problem completely.

Brian

---
   Brian Buchanan    sysop@calbbs.com    brian@wasteland.calbbs.com
-= ArchWizard of Digital Wasteland MOO (wasteland.calbbs.com 8888) =-

• Re: 1.8.0alpha3 delete_verb() bug and patch
• From: "Nate Massey" <natem@ctdnet.acns.nwu.edu>
• Re: 1.8.0alpha3 delete_verb() bug and patch
• From: Pavel Curtis <pavel@parc.xerox.com>

• Prev: Re: 1.8.0a2 / extensions.c
• Next: Re: 1.8.0alpha3 delete_verb() bug and patch
• Index: MOO-cows
• Thread: MOO-cows